Re: cvs: php4 /ext/session mod_user.c

This probably should be zval_ptr_dtor(&retval) instead of zval_dtor() & FREE_ZVAL(). Andi At 16:26 24/12/00 +0000, Sascha Schumann wrote:

sas             Sun Dec 24 08:26:38 2000 EDT

Modified files:

    /php4/ext/session   mod_user.c

Log: Not freeing the zval using FREE_ZVAL caused a segfault in shutdown_memory_manager. Index: php4/ext/session/mod_user.c diff -u php4/ext/session/mod_user.c:1.9 php4/ext/session/mod_user.c:1.10

--- php4/ext/session/mod_user.c:1.9     Wed Oct 11 12:47:15 2000

+++ php4/ext/session/mod_user.c Sun Dec 24 08:26:38 2000 @@ -59,13 +59,13 @@

        if (call_user_function(EG(function_table), NULL, func, retval,
                                argc, argv) == FAILURE) {
                zval_dtor(retval);
-               efree(retval);
+               FREE_ZVAL(retval);
                retval = NULL;
        }

        for (i = 0; i < argc; i++) {
                zval_dtor(argv[i]);
-               efree(argv[i]);
+               FREE_ZVAL(argv[i]);
        }

        return retval;

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/