Re: cvs: php-src /ext/spl php_spl.c

Hello Zeev, Tuesday, August 2, 2005, 10:20:59 AM, you wrote: > At 05:20 02/08/2005, Marcus Boerger wrote: >>helly Mon Aug 1 22:20:04 2005 EDT >> >> Modified files: >> /php-src/ext/spl php_spl.c >> Log: >> - Need to expose this one too >> >>http://cvs.php.net/diff.php/php-src/ext/spl/php_spl.c?r1=1.50&r2=1.51&ty=u >>Index: php-src/ext/spl/php_spl.c >>diff -u php-src/ext/spl/php_spl.c:1.50 php-src/ext/spl/php_spl.c:1.51 >>--- php-src/ext/spl/php_spl.c:1.50 Thu Jul 28 16:59:44 2005 >>+++ php-src/ext/spl/php_spl.c Mon Aug 1 22:20:01 2005 >>@@ -16,7 +16,7 @@ >> >> +----------------------------------------------------------------------+ >> */ >> >>-/* $Id: php_spl.c,v 1.50 2005/07/28 20:59:44 helly Exp $ */ >>+/* $Id: php_spl.c,v 1.51 2005/08/02 02:20:01 helly Exp $ */ >> >> #ifdef HAVE_CONFIG_H >> #include "config.h" >>@@ -153,6 +153,7 @@ >> SPL_ADD_CLASS(ArrayObject, z_list, sub, allow, ce_flags); \ >> SPL_ADD_CLASS(ArrayIterator, z_list, sub, allow, ce_flags); \ >> SPL_ADD_CLASS(BadFunctionCallException, z_list, sub, allow, >> ce_flags); \ >>+ SPL_ADD_CLASS(BadMethodCallException, z_list, sub, allow, ce_flags); \ >> SPL_ADD_CLASS(CachingIterator, z_list, sub, allow, ce_flags); \ >> SPL_ADD_CLASS(CachingRecursiveIterator, z_list, sub, allow, >> ce_flags); \ >> SPL_ADD_CLASS(Countable, z_list, sub, allow, ce_flags); \ > Speaking of coding standards, is there any particular reason we don't > prefix the SPL classes with Spl? We're quickly 'polluting' our class > namespace with more and more classes. That's why dropping namespace support was a very bad i dea and why we need it asap. I suggest we put all SPL classes and interfaces in a spl namespace once we have that. Until that i don't see all classes being prefixed, should i? I fear that if i do we end up in spl:spl... which is kind of suoer ugly isn't it. Anyway what are we doing? Any new class namespaced by extension name sa prefix followed by hyper ugly underscore? Or just the extension name so we end up with just the extension name i ncase of single class support in an ext like we are having in with pdo? I guess in case of spl using 'Spl' as prefix without an underscore is pretty fine for the upcoming classes. Agree? Best regards, Marcus