Re: cvs: php-src /ext/standard type.c

Hi Marcus, but now one can use $array, $float, $int ..., how is_string different? php -r '$array=1;var_dump($array);$print=2;var_dump($print);' int(1) int(2) Andrey Marcus Boerger wrote:

Hello Andrey, not really. Havin it as functions in the engine wouldn't change anything. Having it as opcodes it would be much faster but then all of those would become keywords and that would break tons of scripts (assuming i am not the only one using var names like $is_string, $is_array and such). Saturday, August 13, 2005, 12:22:10 PM, you wrote:

Hi Marcus, isn't it possible to move this into the engine for efficiency reasons?

Andrey

Marcus Boerger wrote:

helly         Sat Aug 13 06:19:32 2005 EDT

 Modified files:                 /php-src/ext/standard     type.c  Log:

- IS_STRING does not necessarily mean ascii so 'standard' is better # Maybe we call them legacy strings http://cvs.php.net/diff.php/php-src/ext/standard/type.c?r1=1.32&r2=1.33&ty=u Index: php-src/ext/standard/type.c diff -u php-src/ext/standard/type.c:1.32 php-src/ext/standard/type.c:1.33 --- php-src/ext/standard/type.c:1.32 Sat Aug 13 06:16:04 2005

+++ php-src/ext/standard/type.c       Sat Aug 13 06:19:31 2005

@@ -16,7 +16,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: type.c,v 1.32 2005/08/13 10:16:04 helly Exp $ */ +/* $Id: type.c,v 1.33 2005/08/13 10:19:31 helly Exp $ */ #include "php.h" #include "php_incomplete_class.h" @@ -309,7 +309,7 @@ /* }}} */ /* {{{ proto bool is_buffer(mixed var) - Returns true if variable is a ascii, unicode or binary string */ + Returns true if variable is a standard, unicode or binary string */ PHP_FUNCTION(is_buffer) {

     pval **arg;

Best regards, Marcus