Re: Test suite for unicode mode (was RE: [PHP-CVS] cvs: php-src / run-tests.php /ext/pdo/tests pdo_001.phpt ...)

On Tue, 16 Aug 2005, Dmitry Stogov wrote: > We discussed this with Andrei long time ago. > I cannot remember did we it internally or in unicode list. It was not on the unicode list. It's nice to talk to the authors of a specific set of code first before pushing large changes into it. (that's what Andrei wants when people do things with PCRE too). > I willn't rollback the patch right now, because this will slowdown PHP > 6 fixing. It is hard to see those failures are bugs and those not. > > I willn't against other good solution and will rollback patch if it'll > occur. > > Right now any test script can be extended with additional section > --UEXPECT--, --UEXPECTF- or --UEXPECTREGEX--, that is uses instead of > --EXPECT-- in unicode mode. If this sections are omitted then regular > --EXPECT-- is used. > > In most cases --UEXPECT...-- section can be get from --EXPECT...-- automatic > by replacing 'string(' to 'unicode(' and '["' to > '[u"'. This automation is > not always right and it doesn't implemented now. > > Any other solutions? The main problem that I've with the current situation that you have to supply a --U section for Unicode tests to work, which is quite annoying. We need to come up with something that allows us to use one --EXPECT--, not sure how yet, but I think we can manage that. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org