Re: cvs: php-src(PHP_4_4) /ext/standard base64.c

Is this going to break apps that relied on this behavior? At 08:33 PM 8/25/2005, Ilia Alshanetsky wrote:

iliaa           Thu Aug 25 23:33:08 2005 EDT

  Modified files:              (Branch: PHP_4_4)
    /php-src/ext/standard       base64.c

Log: MFH: Fixed bug #34214 (base64_decode() does not properly ignore whitespace) http://cvs.php.net/diff.php/php-src/ext/standard/base64.c?r1=1.33.4.6&r2=1.33.4.6.4.1&ty=u Index: php-src/ext/standard/base64.c diff -u php-src/ext/standard/base64.c:1.33.4.6 php-src/ext/standard/base64.c:1.33.4.6.4.1

--- php-src/ext/standard/base64.c:1.33.4.6      Sat Mar  6 14:06:12 2004
+++ php-src/ext/standard/base64.c       Thu Aug 25 23:33:07 2005

@@ -15,7 +15,7 @@

    | Author: Jim Winstead <jimw@php.net>                                  |
    +----------------------------------------------------------------------+

*/ -/* $Id: base64.c,v 1.33.4.6 2004/03/06 19:06:12 iliaa Exp $ */ +/* $Id: base64.c,v 1.33.4.6.4.1 2005/08/26 03:33:07 iliaa Exp $ */ #include <string.h> @@ -153,15 +153,6 @@

        while ((ch = *current++) != '\0' && length-- > 0) {
                if (ch == base64_pad) break;

-           /* When Base64 gets POSTed, all pluses are interpreted as spaces.
-                  This line changes them back.  It's not exactly the Base64 spec,
-                  but it is completely compatible with it (the spec says that
-                  spaces are invalid).  This will also save many people considerable
-                  headache.  - Turadg Aleahmad <turadg@wise.berkeley.edu>
-           */

-

-               if (ch == ' ') ch = '+';

-

                ch = base64_reverse_table[ch];
                if (ch < 0) continue;

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php