cvs: php-src(PHP_5_1) /ext/pdo pdo_stmt.c
| From: | George Schlossnagle | Date: | Thu, 01 Sep 2005 14:44:11 +0000 |
| Subject: | cvs: php-src(PHP_5_1) /ext/pdo pdo_stmt.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-33742@lists.php.net to get a copy of this message | ||
gschlossnagle Thu Sep 1 10:44:11 2005 EDT
Modified files: (Branch: PHP_5_1)
/php-src/ext/pdo pdo_stmt.c
Log:
MFH. Protect against underflow - refs http://pecl.php.net/bugs/bug.php?id=5193
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_stmt.c?r1=1.118&r2=1.118.2.1&ty=u
Index: php-src/ext/pdo/pdo_stmt.c
diff -u php-src/ext/pdo/pdo_stmt.c:1.118 php-src/ext/pdo/pdo_stmt.c:1.118.2.1
--- php-src/ext/pdo/pdo_stmt.c:1.118 Wed Aug 3 14:26:16 2005
+++ php-src/ext/pdo/pdo_stmt.c Thu Sep 1 10:44:11 2005
@@ -18,7 +18,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pdo_stmt.c,v 1.118 2005/08/03 18:26:16 iliaa Exp $ */
+/* $Id: pdo_stmt.c,v 1.118.2.1 2005/09/01 14:44:11 gschlossnagle Exp $ */
/* The PDO Statement Handle Class */
@@ -1541,7 +1541,10 @@
if (FAILURE == zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &colno)) {
RETURN_FALSE;
}
-
+ if(colno < 0) {
+ pdo_raise_impl_error(stmt->dbh, stmt, "42P10", "column number must be
non-negative" TSRMLS_CC);
+ RETURN_FALSE;
+ }
if (!stmt->methods->get_column_meta) {
pdo_raise_impl_error(stmt->dbh, stmt, "IM001", "driver doesn't support
meta data" TSRMLS_CC);
RETURN_FALSE;