Re: cvs: php-src(PHP_5_1) /ext/pdo_sqlite config.m4

Yep, we need to provide a helper function for pdo when built against 5.0 that registers these class constants. --Wez. On 9/25/05, Andreas Korthaus <akorthaus@web.de> wrote: > Marcus Boerger wrote: > > Hello Wez, > > > > i don't see your point here, pdo doesn't build against PHP 5.0 anyway.. > > > PECL PDO does build against PHP 5.1 AND 5.0 (thanks to wez). > > But after the constants -> class constant changes it does not load > anymore into 5.0.5 and 5.1 RC1: > http://pecl.php.net/bugs/bug.php?id=5514 > > (PECL PDO packages only load with the latest PHP snapshot at the moment) > > best regards > Andreas > > PS: I'm talking about the PECL packages, because those are the same > files (some symlinking AFAIR) > > > > Sunday, September 25, 2005, 4:28:47 AM, you wrote: > > > > > >>wez Sat Sep 24 22:28:47 2005 EDT > > > > > >> Modified files: (Branch: PHP_5_1) > >> /php-src/ext/pdo_sqlite config.m4 > >> Log: > >> reinstate this fix for building against PHP 5.0.x. > >> This works fine against PHP 5.1 too; if you revert this, you'd better have an > >> awesome technical reason, or I'll remove your karma. > >> > >> > >> > > >>>>http://cvs.php.net/diff.php/php-src/ext/pdo_sqlite/config.m4?r1=1.26.2.4&r2=1.26.2.5&ty=u > >>Index: php-src/ext/pdo_sqlite/config.m4 > >>diff -u php-src/ext/pdo_sqlite/config.m4:1.26.2.4 > >>php-src/ext/pdo_sqlite/config.m4:1.26.2.5 > >>--- php-src/ext/pdo_sqlite/config.m4:1.26.2.4 Sat Sep 24 19:33:58 2005 > >>+++ php-src/ext/pdo_sqlite/config.m4 Sat Sep 24 22:28:42 2005 > >>@@ -1,4 +1,4 @@ > >>-dnl $Id: config.m4,v 1.26.2.4 2005/09/24 23:33:58 sniper Exp $ > >>+dnl $Id: config.m4,v 1.26.2.5 2005/09/25 02:28:42 wez Exp $ > >> dnl config.m4 for extension pdo_sqlite > >> dnl vim:et:sw=2:ts=2: > >> > >>@@ -83,7 +83,7 @@ > >> > >> PHP_NEW_EXTENSION(pdo_sqlite, > >> $php_pdo_sqlite_sources_core $pdo_sqlite_sources, > >>- $ext_shared,,-I@ext_builddir@/sqlite/src -DPDO_SQLITE_BUNDLED=1 > >>-DSQLITE_OMIT_CURSOR -I$pdo_inc_path) > >>+ $ext_shared,,-I$ext_builddir/sqlite/src -DPDO_SQLITE_BUNDLED=1 > >>-DSQLITE_OMIT_CURSOR -I$pdo_inc_path) > >> > >> PHP_ADD_BUILD_DIR($ext_builddir/sqlite/src, 1) > >> AC_CHECK_SIZEOF(char *,4) > > > > > > > > > > > > Best regards, > > Marcus > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >