Re: cvs: php-src(PHP_5_0) /ext/standard php_incomplete_class.h
| From: | Marcus Boerger | Date: | Mon, 10 Oct 2005 19:25:13 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_0) /ext/standard php_incomplete_class.h | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-34499@lists.php.net to get a copy of this message | ||
Hello Stanislav,
ok, a short lookup showed that we indeed save the length information in the
class as zend_uint. This is wrong since both strlen() and sizeof() return
size_t and both are used on the registering part. Thus the origin is already
wrong.
marcus
Monday, October 10, 2005, 9:17:33 PM, you wrote:
MB>>>> Yes, it is. So you can not use address of size_t instead as zend_uint *, because
MB>>>> when you assign uint *, part of size_t remains unassigned. This is the
MB>>>> source of the bug.
MB>>>
MB>>>Then why don't fix the bug but instead change some valid code?
> I fixed the bug. The bug was exactly to define the value as size_t
> while it is used by functions which require uint* in their API.
> BTW, the fix is identical to the main tree fix introduced 3 monthes ago.
> What's your problem?
> --
> Stanislav Malyshev, Zend Products Engineer
> stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115
Best regards,
Marcus