Re: cvs: php-src(PHP_5_1) /ext/iconv config.m4

On 14.10.2005 00:48, Jani Taskinen wrote:

On Thu, 13 Oct 2005, Antony Dovgal wrote:

On 13.10.2005 23:28, Jani Taskinen wrote:

-      for i in /usr /usr/local; do
-        if test -f "$i/include/iconv.h" -o test -f "$i/include/giconv.h"; then
+      for i in /usr/local /usr; do
+        if test -f "$i/include/iconv.h" || test -f "$i/include/giconv.h"; then

Just curious: what's the problem with -o ? There are a lot of -o all over the sources: find . -name "config.m4" | xargs grep -nH "\-o" | wc -l 51

     Someone claimed -o is not supported in all 'test' implementations.
     Using || is a bit clearer too and definately supported.

So.. Are you going to change all the -o's to || everywhere ? -- Wbr, Antony Dovgal