cvs: php-src(PHP_5_1) /ext/pdo pdo_stmt.c /ext/pdo/tests pecl_bug_5809.phpt
| From: | Wez Furlong | Date: | Sat, 29 Oct 2005 03:01:19 +0000 |
| Subject: | cvs: php-src(PHP_5_1) /ext/pdo pdo_stmt.c /ext/pdo/tests pecl_bug_5809.phpt | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-34859@lists.php.net to get a copy of this message | ||
wez Fri Oct 28 23:01:19 2005 EDT
Added files: (Branch: PHP_5_1)
/php-src/ext/pdo/tests pecl_bug_5809.phpt
Modified files:
/php-src/ext/pdo pdo_stmt.c
Log:
Closes PECL #5809; PDOStatement::execute(array(...)) would modify its args.
It should behave like bindValue() not bindParam().
http://cvs.php.net/diff.php/php-src/ext/pdo/pdo_stmt.c?r1=1.118.2.9&r2=1.118.2.10&ty=u
Index: php-src/ext/pdo/pdo_stmt.c
diff -u php-src/ext/pdo/pdo_stmt.c:1.118.2.9 php-src/ext/pdo/pdo_stmt.c:1.118.2.10
--- php-src/ext/pdo/pdo_stmt.c:1.118.2.9 Mon Oct 24 23:53:25 2005
+++ php-src/ext/pdo/pdo_stmt.c Fri Oct 28 23:01:19 2005
@@ -18,7 +18,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pdo_stmt.c,v 1.118.2.9 2005/10/25 03:53:25 iliaa Exp $ */
+/* $Id: pdo_stmt.c,v 1.118.2.10 2005/10/29 03:01:19 wez Exp $ */
/* The PDO Statement Handle Class */
@@ -368,11 +368,15 @@
}
param.param_type = PDO_PARAM_STR;
- param.parameter = *tmp;
+ MAKE_STD_ZVAL(param.parameter);
+ *param.parameter = **tmp;
+ zval_copy_ctor(param.parameter);
if (!really_register_bound_param(¶m, stmt, 1 TSRMLS_CC)) {
+ zval_ptr_dtor(¶m.parameter);
RETURN_FALSE;
}
+ zval_ptr_dtor(¶m.parameter);
zend_hash_move_forward(Z_ARRVAL_P(input_params));
}
http://cvs.php.net/co.php/php-src/ext/pdo/tests/pecl_bug_5809.phpt?r=1.1&p=1
Index: php-src/ext/pdo/tests/pecl_bug_5809.phpt
+++ php-src/ext/pdo/tests/pecl_bug_5809.phpt