Re: cvs: php-src /ext/reflection config.m4
| From: | Marcus Boerger | Date: | Sat, 19 Nov 2005 17:52:12 +0000 |
| Subject: | Re: cvs: php-src /ext/reflection config.m4 | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-35271@lists.php.net to get a copy of this message | ||
Hello Derick, Jani, Antony,
to bring this (imo) senseless discussion to an end i changed config.m4 to
prevent the extension from being disabled by --disable-all. I think we
should do the same with ext/date, ext/spl, and all that are required by
other exts or that we think are essential (probably also including all that
cannot be built shared).
best regards
marcus
Friday, November 18, 2005, 4:38:11 PM, you wrote:
> On 18.11.2005 18:25, Derick Rethans wrote:
>> On Fri, 18 Nov 2005, Antony Dovgal wrote:
>>
>>> On 18.11.2005 18:08, Derick Rethans wrote:
>>> > On Fri, 18 Nov 2005, Antony Dovgal wrote:
>>> >
>>> > > Not that I care, but if reflection could be disabled with --disable-all,
>>> > > FreeBSD users will never be able to use it, as for some reason which I
>>> > > can't
>>> > > understand, maintainer of PHP port uses --disable-all and builds all
>>> > > extensions as separate packages.
>>> >
>>> > If distributions screw up their packaging it is their fault - not ours.
>>>
>>> Exactly.
>>> But we can think of making PHP a bit harder to screw up, right?
>>
>> --disable-all is not meant for distributions, but they are find to shoot
>> themselves in the foot. I don't see why we should try to prevent that.
>> There is no reason why a distribution should use --disable-all and then
>> compile everything shared. There is no reason for that.
> I do know that.
> But *maintainers* often don't.
> We need at least document it or to add something like this:
> Index: configure.in
> ===================================================================
> RCS file: /repository/php-src/configure.in,v
> retrieving revision 1.579.2.18
> diff -u -p -d -r1.579.2.18 configure.in
> --- configure.in 17 Nov 2005 21:27:56 -0000 1.579.2.18
> +++ configure.in 18 Nov 2005 15:36:43 -0000
> @@ -790,7 +790,10 @@ dnl Check if all enabled by default exte
> dnl
> AC_ARG_ENABLE(all,
> -[ --disable-all Disable all extensions which are enabled by default
> +[ --disable-all Disable all extensions which are enabled by default.
> + ONLY DO THAT IF KNOW WHAT YOU'RE DOING!
> + All default extensions have a good reason to be
> + enabled by default!
> ], [
> PHP_ENABLE_ALL=$enableval
> ])
> --
> Wbr,
> Antony Dovgal
Best regards,
Marcus