RE: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/spl spl.php spl_array.c spl_directory.c spl_engine.c spl_engine.h spl_iterators.c spl_iterators.h spl_sxe.c
/ext/spl/tests array_019.phpt iterator_030.phpt iterator_031.phpt iterator_032.phpt iterator_033.phpt ite

[dmitry@tpl php5.1]$ cat ext/spl/tests/iterator_031.diff 006+ Classes derived from %v must call AppendIterator::__construct() 006- Classes derived from AppendIterator must call AppendIterator::__construct() May be wite spaces? Dmitry. > -----Original Message----- > From: Marcus Boerger [mailto:helly@php.net] > Sent: Monday, March 06, 2006 12:59 PM > To: Dmitry Stogov > Cc: 'Marcus Boerger'; php-cvs@lists.php.net > Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/spl spl.php > spl_array.c spl_directory.c spl_engine.c spl_engine.h > spl_iterators.c spl_iterators.h spl_sxe.c /ext/spl/tests > array_019.phpt iterator_030.phpt iterator_031.phpt > iterator_032.phpt iterator_033.phpt ite > > > Hello Dmitry, > > no test is correct and should work for you as well as for > me. What are you > experiencing? To me it works even under memcheck: > marcus@zaphod /usr/src/PHP_5_1 $ memcheck sapi/cli/php > ext/spl/tests/iterator_031.phpt ==3767== Memcheck, a memory > error detector. ==3767== Copyright (C) 2002-2005, and GNU > GPL'd, by Julian Seward et al. ==3767== Using LibVEX rev > 1471, a library for dynamic binary translation. ==3767== > Copyright (C) 2004-2005, and GNU GPL'd, by OpenWorks LLP. > ==3767== Using valgrind-3.1.0, a dynamic binary > instrumentation framework. ==3767== Copyright (C) 2000-2005, > and GNU GPL'd, by Julian Seward et al. ==3767== For more > details, rerun with: -v ==3767== > --TEST-- > SPL: AppendIterator::append() rewinds when neccessary > --SKIPIF-- > --FILE-- > MyArrayIterator::rewind > 0=>1 > 1=>2 > MyAppendIterator::__construct > MyAppendIterator::append > Classes derived from AppendIterator must call > AppendIterator::__construct() > AppendIterator::getIterator() must be called exactly once per > instance MyAppendIterator::append MyArrayIterator::rewind > MyAppendIterator::append MyAppendIterator::append > MyAppendIterator::rewind MyArrayIterator::rewind > MyAppendIterator::valid 0=>1 MyAppendIterator::valid 1=>2 > MyArrayIterator::rewind MyAppendIterator::valid 0=>1 > MyAppendIterator::valid 1=>2 MyArrayIterator::rewind > MyAppendIterator::valid 0=>1 MyAppendIterator::valid 1=>2 > MyAppendIterator::valid ===DONE=== ==3767== ==3767== ERROR > SUMMARY: 0 errors from 0 contexts (suppressed: 113 from 1) > ==3767== malloc/free: in use at exit: 744 bytes in 10 blocks. > ==3767== malloc/free: 32,962 allocs, 32,952 frees, 2,094,850 > bytes allocated. ==3767== For counts of detected errors, > rerun with: -v ==3767== searching for pointers to 10 > not-freed blocks. ==3767== checked 2,755,496 bytes. ==3767== > ==3767== LEAK SUMMARY: > ==3767== definitely lost: 0 bytes in 0 blocks. > ==3767== possibly lost: 0 bytes in 0 blocks. > ==3767== still reachable: 0 bytes in 0 blocks. > ==3767== suppressed: 744 bytes in 10 blocks. > > best regards > marcus > > Monday, March 6, 2006, 10:14:43 AM, you wrote: > > > Hi Marcus, > > > Probably something wrong with iterator_031.phpt. > > It fails in PHP_5_1. I assume the mistake in test file itself. > > > Thanks. Dmitry. > > >> -----Original Message----- > >> From: Marcus Boerger [mailto:helly@php.net] > >> Sent: Sunday, March 05, 2006 8:40 PM > >> To: php-cvs@lists.php.net > >> Subject: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/spl spl.php > >> spl_array.c spl_directory.c spl_engine.c spl_engine.h > >> spl_iterators.c spl_iterators.h spl_sxe.c /ext/spl/tests > >> array_019.phpt iterator_030.phpt iterator_031.phpt > >> iterator_032.phpt iterator_033.phpt iterato > >> > >> > >> helly Sun Mar 5 17:39:49 2006 UTC > >> > >> Added files: (Branch: PHP_5_1) > >> /php-src/ext/spl/tests array_019.phpt iterator_030.phpt > >> iterator_031.phpt iterator_032.phpt > >> iterator_033.phpt iterator_034.phpt > >> sxe_005.phpt > >> > >> Modified files: > >> /php-src/ext/spl spl.php spl_array.c spl_directory.c > >> spl_engine.c > >> spl_engine.h spl_iterators.c spl_iterators.h > >> spl_sxe.c > >> Log: > >> - Fix issues with not/double calling of constructors of SPL > >> iterators > >> - Fix issues with info-class/file-class in SPL directory > >> handling classes > >> - Add SimpleXMLElement::count() > >> - Drop erroneous RecursiveDirectoryIterator::getSubPathInfo() > >> - Drop dead code > >> - Add tests > >> - Update docu > >> > >> > >> > > > > > Best regards, > Marcus > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > >