Re: cvs: php-src /ext/bz2 bz2_filter.c /ext/standard file.c filters.c streamsfuncs.c user_filters.c /ext/unicode unicode_filter.c /ext/zlib
zlib_filter.c /main php_streams.h /main/streams cast.c filter.c php_stream_filter_api.h streams.c

On Tue, 14 Mar 2006, Sara Golemon wrote: > > "make test" stops work after this patch, because now fgets() always > returns > > FALSE. > > It is not possible for me to commit ZE patches without testing. > > Please fix this ASAP or revert your patches. > > > Sorry about that. Should look good now (though of course there's still > stuff to be done with streams to make it "ready"). I see a segfault with the following valgrind info: ==24701== Syscall param read(buf) points to unaddressable byte(s) ==24701== at 0x503A24E: read (in /lib/tls/libc-2.3.6.so) ==24701== by 0x82ED558: php_stream_fill_read_buffer (streams.c:588) ==24701== by 0x82ED703: _php_stream_read (streams.c:638) ==24701== by 0x824DA76: zif_fread (file.c:1775) ==24701== by 0x8356295: zend_do_fcall_common_helper_SPEC (zend_vm_execute.h:2 09) ==24701== by 0x835BD2A: ZEND_DO_FCALL_SPEC_CONST_HANDLER (zend_vm_execute.h:1 610) ==24701== by 0x8355DED: execute (zend_vm_execute.h:92) ==24701== by 0x831D82F: zend_call_function (zend_execute_API.c:1005) ==24701== by 0x8349208: zend_call_method (zend_interfaces.c:89) ==24701== by 0x8349A2F: zend_user_it_move_forward (zend_interfaces.c:247) ==24701== by 0x836E3BA: ZEND_FE_FETCH_SPEC_VAR_HANDLER (zend_vm_execute.h:783 5) ==24701== by 0x8355DED: execute (zend_vm_execute.h:92) ==24701== Address 0x6498868 is 16 bytes before a block of size 8,192 alloc'd ==24701== at 0x401C422: malloc (vg_replace_malloc.c:149) ==24701== by 0x401D90C: realloc (vg_replace_malloc.c:306) ==24701== by 0x82ED519: php_stream_fill_read_buffer (streams.c:585) ==24701== by 0x82ED703: _php_stream_read (streams.c:638) ==24701== by 0x824DA76: zif_fread (file.c:1775) ==24701== by 0x8356295: zend_do_fcall_common_helper_SPEC (zend_vm_execute.h:2 09) ==24701== by 0x835BD2A: ZEND_DO_FCALL_SPEC_CONST_HANDLER (zend_vm_execute.h:1 610) ==24701== by 0x8355DED: execute (zend_vm_execute.h:92) ==24701== by 0x83563FD: zend_do_fcall_common_helper_SPEC (zend_vm_execute.h:2 43) ==24701== by 0x8356FB4: ZEND_DO_FCALL_BY_NAME_SPEC_HANDLER (zend_vm_execute.h :331) ==24701== by 0x8355DED: execute (zend_vm_execute.h:92) ==24701== by 0x83563FD: zend_do_fcall_common_helper_SPEC (zend_vm_execute.h:2 43) ==24701== ==24701== ---- Attach to debugger ? --- [Return/N/n/Y/y/C/c] ---- No short script yet... I will try. Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org