Re: cvs: php-src(PHP_5_1) /ext/simplexml simplexml.c /ext/tidy tidy.c /ext/xmlreader php_xmlreader.c /ext/xmlwriter php_xmlwriter.c

From:	Antony Dovgal	Date:	Mon, 03 Apr 2006 16:13:00 +0000
Subject:	Re: cvs: php-src(PHP_5_1) /ext/simplexml simplexml.c /ext/tidy tidy.c /ext/xmlreader php_xmlreader.c /ext/xmlwriter php_xmlwriter.c
References:	1 2 3	Groups:	php.cvs
Request:	Send a blank email to php-cvs+get-37645@lists.php.net to get a copy of this message

On 03.04.2006 19:44, Rasmus Lerdorf wrote:

Rasmus Lerdorf wrote:
Antony Dovgal wrote:
+#if (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION == 1 && PHP_RELEASE_VERSION > 2) || (PHP_MAJOR_VERSION == 5 && PHP_MINOR_VERSION > 1) || (PHP_MAJOR_VERSION > 5)
     zend_object_std_dtor(&intern->std TSRMLS_CC);
What about PHP 6?
Ah, never mind on the php 6 part. That last check was hiding on me. But I still would hate to see this huge check a dozen times throughout an extension from now until the end of time.

No, it was decided to use it while we can't bump module API #, i.e. it'll be changed in PHP 5.2. -- Wbr, Antony Dovgal