Re: cvs: php-src /ext/pcre php_pcre.c
| From: | Antony Dovgal | Date: | Mon, 29 May 2006 21:32:04 +0000 |
| Subject: | Re: cvs: php-src /ext/pcre php_pcre.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-38487@lists.php.net to get a copy of this message | ||
On 30.05.2006 01:11, Nuno Lopes wrote:
It has been caught by Johannes actually. Thanks for the hint. -- Wbr, Antony Dovgal@@ -1115,6 +1115,10 @@ } } else { pcre_handle_exec_error(count TSRMLS_CC); + if (result) { + efree(result); + result = NULL; + } break; }Nice catch, Tony! But you don't need the if, because result is never NULL (it is assigned only from safe_malloc()).