Re: cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c
url_scanner_ex.c url_scanner_ex.re var.c /ext/tidy tidy.c /ext/zlib php_zlib.h zlib

Hello Michael, in streams api they at least make sense because the yuse the same technology using in a bunch of zend functions to pass a bit more information about the callee :-) - but here that is not done so i also see no reason for that. best regards marcus Friday, June 2, 2006, 11:08:53 PM, you wrote: > On 03.06.2006 00:56, Andi Gutmans wrote: >> Btw, any reason why we need all those redefinition of functions? If >> it's just to save having to write TSRMLS_C then I'd prefer to remove >> those macros. They just make debugging harder > I have to second that - those macros basically add even more confusion during debugging. > I bet you should know how annoying are similar macros in streams API. >>, there's no real >> benefit and we've tried to be explicit in other places. The patch >> looks nice though although I haven't finished reading through the >> whole thing (I also just found some of the explanations :)Thanks. >> >> +#define php_output_clean() _php_output_clean(TSRMLS_C) >> +PHPAPI int _php_output_clean(TSRMLS_D); >> + >> +#define php_output_clean_all() _php_output_clean_all(TSRMLS_C) >> +PHPAPI void _php_output_clean_all(TSRMLS_D); >> + >> +#define php_output_end() _php_output_end(TSRMLS_C) >> +PHPAPI int _php_output_end(TSRMLS_D); >> + >> +#define php_output_end_all() _php_output_end_all(TSRMLS_C) >> +PHPAPI void _php_output_end_all(TSRMLS_D); >> + >> +#define php_output_discard() _php_output_discard(TSRMLS_C) >> +PHPAPI int _php_output_discard(TSRMLS_D); >> + >> +#define php_output_discard_all() _php_output_discard_all(TSRMLS_C) >> +PHPAPI void _php_output_discard_all(TSRMLS_D); > -- > Wbr, > Antony Dovgal Best regards, Marcus