RE: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c

From: Date: Mon, 10 Jul 2006 12:52:15 +0000
Subject: RE: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c
Groups: php.cvs 
Request: Send a blank email to php-cvs+get-39113@lists.php.net to get a copy of this message
Hi Michael, Seems I was wrong and your patch was correct. It just didn't handle error case. I committed another fix. Please review it. Dmitry. > -----Original Message----- > From: Dmitry Stogov [mailto:dmitry@zend.com] > Sent: Monday, July 10, 2006 4:01 PM > To: 'Michael Wallner' > Cc: 'php-cvs@lists.php.net'; Antony Dovgal (antony@zend.com) > Subject: RE: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c > > > Hi Michael, > > I see. :( > Tony alredy pointed me into this crash. > > I understood the reason of crash in #36949. > It is the "invalid" order of destructors calls. > > Your fix was invalid too. > It caused SIGSEGV in #38003. > But probably it was good-enough workaround. > > You can revert my patch. > > I'll think about fixing "invalid order of destructors calls" > once again, but it is really big problem and may take a lot of time. > > Thanks. Dmitry. > > > -----Original Message----- > > From: Michael Wallner [mailto:mike@php.net] > > Sent: Monday, July 10, 2006 3:33 PM > > To: Dmitry Stogov > > Cc: php-cvs@lists.php.net > > Subject: Re: cvs: php-src(PHP_5_2) / NEWS /ext/mysqli mysqli.c > > > > > > Dmitry Stogov wrote: > > > dmitry Mon Jul 10 10:05:20 2006 UTC > > > > > > Modified files: (Branch: PHP_5_2) > > > /php-src NEWS > > > /php-src/ext/mysqli mysqli.c > > > Log: > > > Fixed bug #38019 (segfault extending mysqli class) > > > > Hi Dmitry, you basically reverted my patch to fix #36949 which > > segfaults again now. Obviously our tests don't really > catch segfaults > > at the end of the script. > > > > mike@honeybadger:~/build/php-5.2-debug$ cli > > /home/mike/cvs/php-5.2/ext/mysqli/tests/bug36949.phpt > > --TEST-- > > bug #36949 > > --SKIPIF-- > > --FILE-- > > 2006-07-10 13:30:38<br> > > 2006-07-10 13:30:38<br> > > --EXPECTF-- > > %d%d%d%d-%d%d-%d%d %d%d:%d%d:%d%d<br> > > %d%d%d%d-%d%d-%d%d %d%d:%d%d:%d%d<br> > > Segmentation fault > > > > > > -- > > Michael > > > > >

« previous php.cvs (#39113) next »