cvs: php-src(PHP_5_2) /ext/dom node.c
| From: | Christian Stocker | Date: | Sun, 16 Jul 2006 16:04:09 +0000 |
| Subject: | cvs: php-src(PHP_5_2) /ext/dom node.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-39273@lists.php.net to get a copy of this message | ||
chregu Sun Jul 16 16:04:09 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/dom node.c
Log:
improved code (after suggestion by helly)
http://cvs.php.net/viewvc.cgi/php-src/ext/dom/node.c?r1=1.37.2.3.2.2&r2=1.37.2.3.2.3&diff_format=u
Index: php-src/ext/dom/node.c
diff -u php-src/ext/dom/node.c:1.37.2.3.2.2 php-src/ext/dom/node.c:1.37.2.3.2.3
--- php-src/ext/dom/node.c:1.37.2.3.2.2 Sun Jul 16 15:03:53 2006
+++ php-src/ext/dom/node.c Sun Jul 16 16:04:09 2006
@@ -17,7 +17,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: node.c,v 1.37.2.3.2.2 2006/07/16 15:03:53 chregu Exp $ */
+/* $Id: node.c,v 1.37.2.3.2.3 2006/07/16 16:04:09 chregu Exp $ */
#ifdef HAVE_CONFIG_H
#include "config.h"
@@ -1870,15 +1870,12 @@
char *value;
- if (zend_parse_method_parameters(ZEND_NUM_ARGS() TSRMLS_CC, getThis(), "O", &id,
dom_node_class_entry) == FAILURE) {
- return;
- }
-
- DOM_GET_OBJ(nodep, id, xmlNodePtr, intern);
+
+ DOM_GET_THIS_OBJ(nodep, id, xmlNodePtr, intern);
value = xmlGetNodePath(nodep);
if (value == NULL) {
- RETURN_EMPTY_STRING();
+ RETURN_NULL();
} else {
RETVAL_STRING(value, 1);
xmlFree(value);