Re: cvs: php-src / run-tests.php

Hi, Marcus Boerger wrote:

Hello Antony, this is definitively wrong, either reenable the zend mm or fix the zend mm. Anyway i was able to run without the old zend mm and with leak check. So my guess is that we are facing new problems that need to be addressed. On gov.php.net until now we were using zend-mm and leak check for the new memory management i was planning to disable MM as well, how else would we find our real memleaks?

valgrind runs? They take really a lot of time but are helpful

best regards marcus Friday, July 28, 2006, 5:58:42 AM, you wrote:

tony2001                Fri Jul 28 12:58:42 2006 UTC

 Modified files:                 /php-src    run-tests.php  Log:

enabling --leak-check was bad idea, since there are way too much false positives caused by the absence of Zend MM http://cvs.php.net/viewvc.cgi/php-src/run-tests.php?r1=1.299&r2=1.300&diff_format=u Index: php-src/run-tests.php diff -u php-src/run-tests.php:1.299 php-src/run-tests.php:1.300 --- php-src/run-tests.php:1.299 Wed Jul 26 11:11:04 2006

+++ php-src/run-tests.php       Fri Jul 28 12:58:42 2006

@@ -23,7 +23,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: run-tests.php,v 1.299 2006/07/26 11:11:04 tony2001 Exp $ */ +/* $Id: run-tests.php,v 1.300 2006/07/28 12:58:42 tony2001 Exp $ */ /* Sanity check to ensure that pcre extension needed by this script is available. * In the event it is not, print a nice error message indicating that this script will @@ -400,7 +400,7 @@

                                       $html_output = is_resource($html_file);
                                       break;
                               case '--version':
-                                       echo '$Revision: 1.299 $'."\n";
+                                       echo '$Revision: 1.300 $'."\n";
                                       exit(1);
                               default:
                                       echo "Illegal switch specified!\n";

@@ -1381,7 +1381,7 @@

       }

       if ($leak_check) {
-               $cmd = "USE_ZEND_ALLOC=0 valgrind -q --tool=memcheck

--trace-children=yes --leak-check=yes --log-file-exactly=$memcheck_filename $cmd";

+               $cmd = "USE_ZEND_ALLOC=0 valgrind -q --tool=memcheck

--trace-children=yes --log-file-exactly=$memcheck_filename $cmd";

       }

       if ($DETAILED) echo "

Best regards, Marcus

Andrey