Re: cvs: php-src(PHP_5_2) /ext/standard string.c
| From: | Stefan Esser | Date: | Tue, 29 Aug 2006 13:15:14 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/standard string.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-40157@lists.php.net to get a copy of this message | ||
> Your imagination is just fabulous.
> "so please think twice before optimizing" means "be careful and do not
> try to optimize this code, even though it looks like it can be
> optimized by moving the emalloc() call to the beginning of the function".
> Please try to understand what I've really said before posting your
> comments again.
>
Please do not commit obvious integer overflows to the code of PHP again.
It actually doesn't matter what you meant. You removed an possible
overflow and replaced it with another possible overflow. So please "be
careful and do not try to fix code, when all you come up with is just a
different kind of overflow".
Stefan