Re: cvs: php-src(PHP_5_2) /ext/dom entityreference.c
| From: | Antony Dovgal | Date: | Thu, 14 Sep 2006 13:40:50 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/dom entityreference.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-40498@lists.php.net to get a copy of this message | ||
On 14.09.2006 17:35, Rob Richards wrote:
rrichards Thu Sep 14 13:35:02 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/dom entityreference.c Log:
fix bug #38813 (DOMEntityReference->__construct crashes when called explicitly)
Rob, while you're at it, what do you think of such patch ?
Index: ext/dom/characterdata.c
===================================================================
RCS file: /repository/php-src/ext/dom/characterdata.c,v
retrieving revision 1.15.2.1
diff -u -p -d -r1.15.2.1 characterdata.c
--- ext/dom/characterdata.c 1 Jan 2006 12:50:06 -0000 1.15.2.1 +++ ext/dom/characterdata.c 14 Sep 2006 13:40:07 -0000@@ -208,9 +208,10 @@ PHP_FUNCTION(dom_characterdata_append_da
DOM_GET_OBJ(nodep, id, xmlNodePtr, intern);
- xmlTextConcat(nodep, arg, arg_len);-
- RETURN_TRUE;
+ if (!xmlTextConcat(nodep, arg, arg_len)) {
+ RETURN_TRUE;
+ }
+ RETURN_FALSE;
}
/* }}} end dom_characterdata_append_data */
--
Wbr,
Antony Dovgal