RE: [PHP-CVS] cvs: php-src /ext/date php_date.c /ext/dom node.c /ext/filter logical_filters.c /ext/session session.c /ext/simplexml
simplexml.c /ext/soap php_encoding.c php_packet_soap.c soap.c /ext/sqlite sqlite.c /ext/stand
| From: | Dmitry Stogov | Date: | Wed, 20 Sep 2006 06:29:48 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php-src /ext/date php_date.c /ext/dom node.c /ext/filter logical_filters.c /ext/session session.c /ext/simplexml simplexml.c /ext/soap php_encoding.c php_packet_soap.c soap.c /ext/sqlite sqlite.c /ext/stand |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-40623@lists.php.net to get a copy of this message | ||
Hi Derick,
Seems that fix for test file is wrong.
In unicode mode most strings must be represented by unicode.
Probably something wasn't fixed in ext/date.
I think OO ext/date extensions were not enabled for me, and I didn't see
failure of this test.
I tried to fix as much places as possible, but I am not able to find all of
them.
Please check this by you self.
Thanks. Dmitry.
> -----Original Message-----
> From: Derick Rethans [mailto:derick@php.net]
> Sent: Wednesday, September 20, 2006 9:10 AM
> To: Dmitry Stogov
> Cc: php-cvs@lists.php.net
> Subject: RE: [PHP-CVS] cvs: php-src /ext/date php_date.c
> /ext/dom node.c /ext/filter logical_filters.c /ext/session
> session.c /ext/simplexml simplexml.c /ext/soap php_encoding.c
> php_packet_soap.c soap.c /ext/sqlite sqlite.c /ext/stand
>
>
> On Wed, 20 Sep 2006, Dmitry Stogov wrote:
>
> > You are right . Extensions should use string/unicode keys (not
> > binary). However now you should use add_ascii_assoc_...() functions
> > instead of
> > add_assoc_...() to make autoconversion work.
> > This is probably the only change that patch makes in extensions.
>
> Actually not, as Antony had to change one of the date tests:
>
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/date/tests/oo_002.ph
> pt?r1=1.3&r2=1.4&diff_format=u
> Index: php-src/ext/date/tests/oo_002.phpt
> diff -u php-src/ext/date/tests/oo_002.phpt:1.3
> php-src/ext/date/tests/oo_002.phpt:1.4
> --- php-src/ext/date/tests/oo_002.phpt:1.3 Tue Aug 29
> 22:24:23 2006
> +++ php-src/ext/date/tests/oo_002.phpt Tue Sep 19 11:26:53 2006
> @@ -31,5 +31,5 @@
> unicode(29) "Tue, 01 Aug 06 13:00:00 +0000"
> unicode(29) "Tue, 01 Aug 06 14:00:00 +0000"
> unicode(29) "Tue, 01 Aug 06 12:59:59 +0000"
> -unicode(10) "Asia/Tokyo"
> -unicode(10) "Asia/Tokyo"
> +string(10) "Asia/Tokyo"
> +string(10) "Asia/Tokyo"
>
> So it seems that something is going wrong still?
>
> regards,
> Derick
>
> --
> Derick Rethans
> http://derickrethans.nl |
> http://ez.no | http://xdebug.org
>