Re: cvs: php-src(PHP_5_2) /ext/exif exif.c
| From: | Nuno Lopes | Date: | Sat, 04 Nov 2006 21:48:23 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/exif exif.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-41364@lists.php.net to get a copy of this message | ||
Hi Marcus!
you are probably referring to the "warnings" pointed out by http://gcov.php.net/viewer.php?version=PHP_5_2&func=params&file=cc163453976b65334f071d1d4f976ef45
But that script currently produces too many false positives.. in this case it doesn't seem (from a quick code analysis) that those vars need to be initialized. Ilia asked me for a functionality similar to what Coverity provides, that is allow php.net developers to mark some warnings as bogus. I prefer that solution opposed to start initializing everything..
Nuno
----- Original Message -----
helly Sat Nov 4 20:46:32 2006 UTCModified files: (Branch: PHP_5_2)/php-src/ext/exif exif.c Log: - MFH: Make parameter parsing api check happy http://cvs.php.net/viewvc.cgi/php-src/ext/exif/exif.c?r1=1.173.2.5.2.4&r2=1.173.2.5.2.5&diff_format=u Index: php-src/ext/exif/exif.c diff -u php-src/ext/exif/exif.c:1.173.2.5.2.4 php-src/ext/exif/exif.c:1.173.2.5.2.5 --- php-src/ext/exif/exif.c:1.173.2.5.2.4 Tue Oct 10 22:22:43 2006 +++ php-src/ext/exif/exif.c Sat Nov 4 20:46:32 2006 @@ -4005,7 +4005,7 @@ Reads the embedded thumbnail */ PHP_FUNCTION(exif_thumbnail) { - zval *p_width, *p_height, *p_imagetype; + zval *p_width = 0, *p_height = 0, *p_imagetype = 0; char *p_name; int p_name_len, ret, arg_c = ZEND_NUM_ARGS(); image_info_type ImageInfo;