Re: cvs: php-src(PHP_5_2) /ext/date/lib parse_tz.c
| From: | Hannes Magnusson | Date: | Fri, 10 Nov 2006 22:27:24 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/date/lib parse_tz.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-41471@lists.php.net to get a copy of this message | ||
Hi Nuno
This patch causes ext/date/tests/timezones.phpt to segfault...
-Hannes
On 11/10/06, Nuno Lopes <nlopess@php.net> wrote:
nlopess Fri Nov 10 17:32:15 2006 UTCModified files: (Branch: PHP_5_2) /php-src/ext/date/lib parse_tz.cLog: mark the binary search delimiters as unsigned, so that the compiler can use a quick shift operation http://cvs.php.net/viewvc.cgi/php-src/ext/date/lib/parse_tz.c?r1=1.20.2.6.2.6&r2=1.20.2.6.2.7&diff_format=u Index: php-src/ext/date/lib/parse_tz.c diff -u php-src/ext/date/lib/parse_tz.c:1.20.2.6.2.6 php-src/ext/date/lib/parse_tz.c:1.20.2.6.2.7--- php-src/ext/date/lib/parse_tz.c:1.20.2.6.2.6 Fri Sep 1 23:25:29 2006 +++ php-src/ext/date/lib/parse_tz.c Fri Nov 10 17:32:15 2006@@ -16,7 +16,7 @@+----------------------------------------------------------------------+*/ -/* $Id: parse_tz.c,v 1.20.2.6.2.6 2006/09/01 23:25:29 nlopess Exp $ */ +/* $Id: parse_tz.c,v 1.20.2.6.2.7 2006/11/10 17:32:15 nlopess Exp $ */ #include "timelib.h" @@ -192,7 +192,7 @@}} -static int tz_search(char *timezone, int left, int right, const timelib_tzdb *tzdb) +static int tz_search(char *timezone, unsigned int left, unsigned int right, const timelib_tzdb *tzdb) {int mid, cmp;-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php