Re: cvs: php-src /ext/zip php_zip.c

From: Date: Sun, 12 Nov 2006 00:55:02 +0000
Subject: Re: cvs: php-src /ext/zip php_zip.c
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-41489@lists.php.net to get a copy of this message
Hello, On 11/12/06, Nuno Lopes <nlopess@php.net> wrote: It sounds wrong. _zip_free is a private function and is used in zip_close. Can you do it there instead? itself.oo_delete.phpt works here, which error do you have? --Pierre
Yes, I also thought that it was a private function, but I really had to use it. The problem arises when zip_close() returns -1 (that was happending with me)
oo_delete failed on your box? Weird, it works here on all my test systems. What do you use?
I was testing in my gentoo box (x86). I was failing because of permission problems (AFAIR).
and that function doesn't call _zip_free() on error (so that you can retrieve the error), thus creating a memleak.
Yes I realized that now, I will add a public function to destroy a za, _zip_free must stay behind the scene :)
OK, sure. Ah, there are a few more places where zip_free() needs to be called (basically everytime after zip_close()). Nuno

« previous php.cvs (#41489) next »