RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c
| From: | Dmitry Stogov | Date: | Wed, 15 Nov 2006 18:00:35 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-41589@lists.php.net to get a copy of this message | ||
Hi Pierre,
I think that changing global behavior (_fmode = _O_BINARY;) is not a good
idea.
May be this code should be removed from CGI and CLI too.
May be we have a bug somewhere and _O_BINARY is not passed to open().
Do you think the bug is in CRT?
What VC version do you use?
Dmitry.
> -----Original Message-----
> From: Pierre [mailto:pierre.php@gmail.com]
> Sent: Wednesday, November 15, 2006 8:41 PM
> To: Dmitry Stogov
> Cc: Pierre-Alain Joye; php-cvs@lists.php.net; Wez Furlong
> Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip/lib zip_open.c
>
>
> On 11/15/06, Dmitry Stogov <dmitry@zend.com> wrote:
> > I am not sure in this patch, because it changes the whole process
> > behavior. May be you need add character "b" into 'mode'
> then you open
> > zip archive?
>
> Please check:
>
> http://news.php.net/php.internals/26606
>
> Can we discuss the issue there?
>
> --Pierre
>