Re: cvs: php-src /ext/ftp/tests 005.phpt bug39583-2.phpt bug39583.phpt bug7216-2.phpt server.inc

Nuno, I am just wondering if perhaps we can adjust test 005 in such a way as it would not fail, creating a false positive for an error that does not exist. One way to do it would be to replace the response message with %s. On 26-Nov-06, at 12:57 PM, Nuno Lopes wrote:

Hi Ilia, The tests I've made to the ftp extension most do really depend on the ftp server implementation. They really need that simple server.inc implementation, so that the return values are equal. Any server implementation can change its messages, so there is nothing we can do about it.. My initial thoughs on these tests were more about regression testing, because I spotted some (already-fixed) bugs that crashed PHP with certain input from the server. I want to add tests for these bug reports. These tests also provide testing for the streams API (for example, AFAIR the test 002 is crashing on ia64 - Tony told me). Nuno ----- Original Message -----

Nuno, The test 005 does not seem to be entirely reliable and it may return different results depending on the ftp server implementation. For example on my system the errors you have returning FTP_ASCII are shown as Command not implemented. On 24-Nov-06, at 10:50 AM, Nuno Lopes wrote:

nlopess Fri Nov 24 15:50:46 2006 UTC Modified files:

    /php-src/ext/ftp/tests bug39583-2.phpt bug39583.phpt 005.phpt
                          bug7216-2.phpt server.inc

Log: MFB

Ilia Alshanetsky