Re: cvs: php-src(PHP_5_2) /ext/gd gd.c php_gd.h

From: Date: Wed, 10 Jan 2007 03:11:32 +0000
Subject: Re: cvs: php-src(PHP_5_2) /ext/gd gd.c php_gd.h
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-42644@lists.php.net to get a copy of this message
On 1/9/07, Nuno Lopes <nlopess@php.net> wrote:
On Mon, 8 Jan 2007, Nuno Lopes wrote:
nlopess Mon Jan 8 22:52:23 2007 UTC
  Modified files:              (Branch: PHP_5_2)
    /php-src/ext/gd gd.c php_gd.h
Log: avoid calling MSHUTDOWN when built without libt1
Is it really needed to clog the source code with those ifdefs? It's not like this is a performance issue here... I don't think this is "clogging" the code. I also think that any "free" speedup is welcome (even minor). Anyway this part of the code is rarely changed, so it shouldn't be any nightmare to maintain. (the ifdef was already there. I just moved it around)
As I said, I have no real problem with such changes. I just feel like they should not be done in a RC phase. Cleanup or "speedup" are otherwise welcome :) --Pierre

« previous php.cvs (#42644) next »