cvs: php-src /ext/mysqli mysqli_api.c
| From: | Andrey Hristov | Date: | Fri, 12 Jan 2007 20:26:35 +0000 |
| Subject: | cvs: php-src /ext/mysqli mysqli_api.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-42705@lists.php.net to get a copy of this message | ||
andrey Fri Jan 12 20:26:35 2007 UTC
Modified files:
/php-src/ext/mysqli mysqli_api.c
Log:
add a sticky note
http://cvs.php.net/viewvc.cgi/php-src/ext/mysqli/mysqli_api.c?r1=1.142&r2=1.143&diff_format=u
Index: php-src/ext/mysqli/mysqli_api.c
diff -u php-src/ext/mysqli/mysqli_api.c:1.142 php-src/ext/mysqli/mysqli_api.c:1.143
--- php-src/ext/mysqli/mysqli_api.c:1.142 Sat Jan 6 05:50:36 2007
+++ php-src/ext/mysqli/mysqli_api.c Fri Jan 12 20:26:35 2007
@@ -15,7 +15,7 @@
| Author: Georg Richter <georg@php.net> |
+----------------------------------------------------------------------+
- $Id: mysqli_api.c,v 1.142 2007/01/06 05:50:36 georg Exp $
+ $Id: mysqli_api.c,v 1.143 2007/01/12 20:26:35 andrey Exp $
*/
#ifdef HAVE_CONFIG_H
@@ -686,6 +686,11 @@
if (!ret) {
#endif
for (i = 0; i < stmt->result.var_cnt; i++) {
+ /*
+ QQ: Isn't it quite better to call zval_dtor(). What if the user has
+ assigned a resource, or an array to the bound variable? We are going
+ to leak probably. zval_dtor() will handle also Unicode/Non-unicode mode.
+ */
/* Even if the string is of length zero there is one byte alloced so efree() in all cases */
if (Z_TYPE_P(stmt->result.vars[i]) == IS_STRING) {
efree(stmt->result.vars[i]->value.str.val);