Re: cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c
| From: | Pierre | Date: | Sun, 14 Jan 2007 13:19:28 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/gd/libgd gd.c | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-42721@lists.php.net to get a copy of this message | ||
Hello Nuno,
On 1/14/07, Nuno Lopes <nlopess@php.net> wrote:
It is reproducible everywhere, I must say (including my pc). wx2 is the size of the array, so you can only read from idx 0 to (wx2-1). Reading idx wx2 doesn't make sense.Right, I was wondering why valgrind don't say a word here, will reinstall it...
For statistics, the gcov machine has Debian stable (gcc 3.3) and a Celeron cpu.It is not only for statistic purporses.
How is B true there if it must be false to enter in the 'for' loop? It can't. Anyway you are the extension maintainer, so feel free to revert the patch and/or not merge it to libgd.Long story short: I Like to keep this little comment. There is no technical reason (there was none before, as my comment said, there is still none now) to do it but I like to keep it as a comment. And I do not want to revert the patch but I will reintroduce the comment. I still ask to do not make such changes during a RC phase (optimization/cleanup should not be done during this phase), that's all :)
Being the first does not matter, but only before the commit, I hate arguing like we are doing now when the topic of the discussion is already in CVS :) Cheers, --PierreI like to first see a patch for this optimization. There is many special cases or things to worry about here and BC is important. I'm not saying that an optimization is not possible or welcome, only that I like to see it prior to commit. Sure. I said I wasn't going to make it for now (before php 5.2.1 is released). After that I can look at it (and no, it won't have any BC issues). You'll be the first to read it, don't worry ;)The code can still be further optimized when using square images, but I didn't deliberately make such change in an RC phase and without your approval.