Re: cvs: php-src(PHP_5_2) /ext/mysqli mysqli_nonapi.c

Hi, Antony Dovgal wrote: > On 04/14/2007 07:30 PM, Andrey Hristov wrote: >> doing this is definitely bad. Probably it makes mysql_ping() to work but >> having reconnect being disabled has its reasons. > > http://php.net/mysqli_ping > mysqli_ping, mysqli->ping() — Pings a server connection, or *tries to > reconnect if the connection has gone down* Then the fix is wrong, it should set reconnect only for the mysql_ping call, if reconnect is off. >> Once connection is >> broken TXs are lost, connection variables too. Reconnecting under the >> hood is bad behavior. mysql_ping() can work without mysql->reconnect >> being set to 1. It will just won't reconnect and return an error. Which >> I think is pretty normal. > > It's not because it's expected to reconnect. > >> The app should check and decide whether to >> reconnect or die. Thus, please _revert_ the patches you committed to >> ext/mysql and ext/mysqli. The report is bogus. >> Even if the report wasn't bogus, the fix is not complete, as for >> 5.0.3 < libmysql < 5.0.13 , it doesn't work. > > As far as I understand, there is no way to fix it in versions between > 5.0.3 and 5.0.13 because of MySQLI API breakage. > It's just about setting mysql->reconnect in this cases. This versions won't change anyway, they are released. Andrey