Re: cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h
| From: | Antony Dovgal | Date: | Tue, 17 Apr 2007 18:31:57 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h | ||
| References: | 1 2 3 4 5 6 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-43928@lists.php.net to get a copy of this message | ||
On 04/17/2007 10:25 PM, Pierre Joye wrote:
On 4/17/07, Antony Dovgal <antony@zend.com> wrote:What are you referring to (and why does it mean adding new functions in RC is ok) ?On 04/17/2007 09:53 PM, Pierre Joye wrote:On 4/17/07, Antony Dovgal <antony@zend.com> wrote:Well, do you really see a problem in these two self contained functions? They don't affect anything else in ext/gd or php and are on windows only.Hello Pierre-Alain, since when are we adding major new features to release branches?On 04/17/2007 09:29 PM, Marcus Boerger wrote:Pierre, please leave this function for HEAD only, we don't add new features to 5.2.Don't get me wrong, it's not about you or the functions. We have some rules and I believe everybody should abide by them.Yes, I know. I only think that there is plenty of other changes in 5_2 that I would never allow (since RC1) and we will have a RC2.
I do think that's a good opportunity to push these two little functions in (the final versions are much larger) If there is any problem during the RC2 phase, I can #ifdef 0 them in seconds :)#ifdef 0 works for me. -- Wbr, Antony Dovgal