Re: cvs: php-src(PHP_5_2) / NEWS /win32 registry.c
| From: | Ilia Alshanetsky | Date: | Wed, 02 May 2007 16:24:08 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / NEWS /win32 registry.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-44145@lists.php.net to get a copy of this message | ||
Dmitry,
The registry patch can stay, but please revert the soap and zend_compile changes until Friday.
On 2-May-07, at 12:17 PM, Dmitry Stogov wrote:
Hi Ilia, The registry.c definitely must not be reverted. It fixes serious regression since 5.1.6. I can revert ext/soap and zend_compile.c fixes that I made today to not delay release process, but I don't think they may break more than zend_fcall_info_init() fix by Johannes. So it probably should be reverted too. Could you send something like "CVS IS CLOSED BECAUSE OF PHP-?.?.? RELEASE PROCESS" into internals@ next times. It would save our time and nerves. Thanks. Dmitry.Ilia Alshanetsky-----Original Message----- From: Ilia Alshanetsky [mailto:ilia@prohost.org] Sent: Wednesday, May 02, 2007 5:25 PM To: Stanislav Malyshev Cc: Antony Dovgal; Dmitry Stogov; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /win32 registry.c Let's leave this one in then, but please revert the other changes. 5.2.2 will be packed today, so by Friday the changes can go back into the CVS. On 2-May-07, at 9:11 AM, Stanislav Malyshev wrote:--PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.phpreason to letFrom what I understand, this patch fixes broken registry .ini control in PHP on windows. It seems to eb quite isolated and if I understand the nature of the bug correctly without the fix the registry per-dir entries don't work. So it might be aRegression from 5.2.1 or earlier?As far as I understand, it's been broken in 5.2.1 and this patch fixes it.this in as an exception. -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/Ilia Alshanetsky --PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php