Re: cvs: php-src(PHP_4_4) / NEWS /ext/standard dir.c

Hi Ilia, Derick, On 6/22/07, Derick Rethans <derick@php.net> wrote:

On Tue, 12 Jun 2007, Ilia Alshanetsky wrote:

iliaa         Tue Jun 12 12:56:17 2007 UTC

  Modified files:              (Branch: PHP_4_4)
    /php-src  NEWS
    /php-src/ext/standard     dir.c

Log: MFB: Fixed bug #41655 (open_basedir bypass via glob()) This commit breaks the compile on: gcc (GCC) 4.1.2 (Ubuntu 4.1.2-0ubuntu4) gcc (GCC) 4.1.3 20070601 (prerelease) (Debian 4.1.2-12) with the following error: /home/derick/dev/php/php-4.4dev/ext/standard/dir.c: In function 'zif_glob': /home/derick/dev/php/php-4.4dev/ext/standard/dir.c:387: error: void value not ignored as it ought to be make: *** [ext/standard/dir.lo] Error 1

php 5+'s php_dirname works in place without altering the path. That's not the case in 4.x. Only choice is to duplicate it before calling dirname. http://pecl.php.net/~pierre/41655.4_4.patch.txt is a possible fix. I did not test it directly (make test passes :). I only fixed my build :D hth, --Pierre