Re: cvs: php-src(PHP_5_2) /ext/xmlwriter/tests 007.phpt OO_007.phpt
| From: | Rob Richards | Date: | Tue, 26 Jun 2007 11:49:21 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) /ext/xmlwriter/tests 007.phpt OO_007.phpt | ||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-44979@lists.php.net to get a copy of this message | ||
Antony Dovgal wrote:
On 25.06.2007 22:24, Rob Richards wrote:Personally I'd prefer just to disable the test when LIBXML_VERSION < 20629 (using Dmitry's updated test) instead of having to have multiple tests for different libxml2 versions and seeing the output is really correct in the newer version. RobChanged output is due to a I fix I made in libxml2 for 2.6.29So we need either to create separate tests for 2.6.29 or just disable these tests when LIBXML_VERSION => 20629, if I understood it correctly. That is correct. As Dmitry pointed out older libxml2 produced invalid XML, but that particular test is for a non-related PHP issue in the extension.