cvs: php-src /main php_variables.c

tony2001 Wed Jul 18 11:46:28 2007 UTC Modified files: /php-src/main php_variables.c Log: add comment (the code is not that obvious indeed) http://cvs.php.net/viewvc.cgi/php-src/main/php_variables.c?r1=1.142&r2=1.143&diff_format=u Index: php-src/main/php_variables.c diff -u php-src/main/php_variables.c:1.142 php-src/main/php_variables.c:1.143 --- php-src/main/php_variables.c:1.142 Tue Jun 5 11:24:13 2007 +++ php-src/main/php_variables.c Wed Jul 18 11:46:28 2007 @@ -17,7 +17,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: php_variables.c,v 1.142 2007/06/05 11:24:13 tony2001 Exp $ */ +/* $Id: php_variables.c,v 1.143 2007/07/18 11:46:28 tony2001 Exp $ */ #include <stdio.h> #include "php.h" @@ -141,6 +141,8 @@ zend_hash_del(ht, var, var_len + 1); zval_dtor(val); + /* do not output the error message to the screen, + this helps us to to avoid "information disclosure" */ if (!PG(display_errors)) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Input variable nesting level exceeded %ld. To increase the limit change max_input_nesting_level in php.ini.", PG(max_input_nesting_level)); } @@ -293,6 +295,8 @@ zend_u_hash_del(ht, IS_UNICODE, tmp_var, var_len + 1); zval_dtor(val); + /* do not output the error message to the screen, + this helps us to to avoid "information disclosure" */ if (!PG(display_errors)) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Input variable nesting level exceeded %ld. To increase the limit change max_input_nesting_level in php.ini.", PG(max_input_nesting_level)); }