Re: cvs: php4 /pear pear.m4
| From: | (Stig Sæther Bakken) | Date: | Tue, 13 Mar 2001 21:45:45 +0000 |
| Subject: | Re: cvs: php4 /pear pear.m4 | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-4549@lists.php.net to get a copy of this message | ||
This is not different from the way it works in PHP. The problem is
that if you have an extension that uses "phpize" to make its own
configure script etc, and you want to define your own variables there,
configure will make a file called "php_config.h". Unless you
explicitly put "." in your include path in Makefile.in that is not the
file you get with #include "php_config.h". That include statement
will by default read $prefix/include/php/php_config.h. So to include
your module's config header file, you must do #include
"./php_config.h", which is kinda silly.
This patch renames the _extension local_ config header to "config.h"
to clear up this confusion.
- Stig
[Andi Gutmans <andi@zend.com>]
> What is the reason for this? Shouldn't we keep it the way it works
> within the PHP tree? Some modules include php_config.h or do you also
> have that in PEAR?
>
> Andi
>
> At 09:54 AM 3/12/2001 +0000, Stig Bakken wrote:
> >ssb Mon Mar 12 01:54:26 2001 EDT
> >
> > Modified files:
> > /php4/pear pear.m4
> > Log:
> > HEADS UP: renamed config header file in "phpize"d extensions to
> > "config.h" rather than "php_config.h".
> >
> >
> >Index: php4/pear/pear.m4
> >diff -u php4/pear/pear.m4:1.7 php4/pear/pear.m4:1.8
> >--- php4/pear/pear.m4:1.7 Mon Oct 30 10:27:46 2000
> >+++ php4/pear/pear.m4 Mon Mar 12 01:54:26 2001
> >@@ -81,6 +81,6 @@
> > test -d modules || mkdir modules
> > touch .deps
> >
> >-AC_CONFIG_HEADER(php_config.h)
> >+AC_CONFIG_HEADER(config.h)
> >
> > AC_OUTPUT()
> >
> >
> >
> >--
> >PHP CVS Mailing List (http://www.php.net/)
> >To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net
> >For additional commands, e-mail: php-cvs-help@lists.php.net
> >To contact the list administrators, e-mail: php-list-admin@lists.php.net
>
--
Stig Sæther Bakken <ssb@fast.no>
Fast Search & Transfer ASA, Trondheim, Norway