Re: cvs: php-src(PHP_5_2) /ext/standard/tests/file fgetcsv_error.phpt

Hi Tony, The purpose of testcase (fgetcsv_variation14.phpt) is to read from end of file.The use of feof() in the testcase is to check for the file pointer pointing to end of file. This check is required to confirm the position of file pointer before and after the read function by fgetcsv(). I think this check is required here. Regards Nikhil On 8/9/07, Nikhil Gupta <nikhil.success@gmail.com> wrote: > > Hi Tony, > > The purpose of testcase (fgetcsv_variation14.phpt) is to read from end of > file.The use of feof() in the testcase is to check for the file pointer > pointing to end of file. This check is required to confirm the position of > file pointer before and after the read function by fgetcsv(). I think this > check is required here. > > Regards > Nikhil > > On 8/9/07, Antony Dovgal <antony@zend.com> wrote: > > > > The tests below fail because of feof() returning bool(false) instead of > > expected bool(true) > > (dunno why its return value is even checked, the test is supposed to > > test fgetcsv(), not feof()). > > > > ext/standard/tests/file/fgetcsv_variation14.phpt > > ext/standard/tests/file/fgetcsv_variation2.phpt > > ext/standard/tests/file/fgetcsv_variation22.phpt > > ext/standard/tests/file/fgetcsv_variation29.phpt > > ext/standard/tests/file/fgetcsv_variation30.phpt > > ext/standard/tests/file/fgetcsv_variation31.phpt > > > > > > On 08.08.2007 17:13, Raghubansh Kumar wrote: > > > kraghuba Wed Aug 8 13:13:18 2007 UTC > > > > > > Added files: (Branch: PHP_5_2) > > > /php-src/ext/standard/tests/file fgetcsv_variation27.phpt > > > > > > -- > > Wbr, > > Antony Dovgal > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > >