Re: cvs: php-src(PHP_5_2) /ext/standard/tests/strings chunk_split_variation2.phpt chunk_split_variation5.phpt chunk_split_variation8.phpt

Hello Antony, this is not about fixing BUGS as in PHP behaves wrong. This is about consistency. We decided on a format for all error messages and Jani was enforcing that. Anyway, it does not matter how long something wrong is in the codebase. Longer errors are not better errors. They only tend to get loved and become features..... The real issue here is in fact that you might want to write a strict rule for parsing errors, with some errors having dots and some not it is harder to get the real text. marcus Monday, October 1, 2007, 12:22:43 PM, you wrote: > tony2001 Mon Oct 1 10:22:43 2007 UTC > Modified files: (Branch: PHP_5_2) > /php-src/ext/standard/tests/strings chunk_split_variation2.phpt > chunk_split_variation5.phpt > chunk_split_variation8.phpt > Log: > these dots exist since PHP3 > even though Jani removed them in 5_3, I can't see how they can cause any BUGS > > > > http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/strings/chunk_split_variation2.phpt?r1=1.1.2.1&r2=1.1.2.2&diff_format=u > Index: php-src/ext/standard/tests/strings/chunk_split_variation2.phpt > diff -u > php-src/ext/standard/tests/strings/chunk_split_variation2.phpt:1.1.2.1 > php-src/ext/standard/tests/strings/chunk_split_variation2.phpt:1.1.2.2 > --- > php-src/ext/standard/tests/strings/chunk_split_variation2.phpt:1.1.2.1 Sat Sep 29 12:55:34 > 2007 > +++ php-src/ext/standard/tests/strings/chunk_split_variation2.phpt Mon Oct 1 10:22:43 > 2007 > @@ -95,21 +95,21 @@ > string(28) "This is ch*uklen vari*ation*" > -- Iteration 2 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 3 -- > string(26) "This is chuklen variation*" > -- Iteration 4 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 5 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 6 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 7 -- > string(50) "T*h*i*s* *i*s* *c*h*u*k*l*e*n* *v*a*r*i*a*t*i*o*n*" > @@ -121,39 +121,39 @@ > string(50) "T*h*i*s* *i*s* *c*h*u*k*l*e*n* *v*a*r*i*a*t*i*o*n*" > -- Iteration 11 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 12 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 13 -- > string(50) "T*h*i*s* *i*s* *c*h*u*k*l*e*n* *v*a*r*i*a*t*i*o*n*" > -- Iteration 14 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 15 -- > string(50) "T*h*i*s* *i*s* *c*h*u*k*l*e*n* *v*a*r*i*a*t*i*o*n*" > -- Iteration 16 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 17 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 18 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 19 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 20 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 21 -- > > @@ -161,11 +161,11 @@ > string(50) "T*h*i*s* *i*s* *c*h*u*k*l*e*n* *v*a*r*i*a*t*i*o*n*" > -- Iteration 22 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 23 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 24 -- > string(30) "This *is ch*uklen* vari*ation*" > > http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/strings/chunk_split_variation5.phpt?r1=1.1.2.1&r2=1.1.2.2&diff_format=u > Index: php-src/ext/standard/tests/strings/chunk_split_variation5.phpt > W£ú > üeù+äƒÛeïhttp://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/strings/chunk_split_variation8.phpt?r1=1.1.2.1&r2=1.1.2.2&diff_format=u > Index: php-src/ext/standard/tests/strings/chunk_split_variation8.phpt > diff -u > php-src/ext/standard/tests/strings/chunk_split_variation8.phpt:1.1.2.1 > php-src/ext/standard/tests/strings/chunk_split_variation8.phpt:1.1.2.2 > --- > php-src/ext/standard/tests/strings/chunk_split_variation8.phpt:1.1.2.1 Sat Sep 29 12:55:34 > 2007 > +++ php-src/ext/standard/tests/strings/chunk_split_variation8.phpt Mon Oct 1 10:22:43 > 2007 > @@ -51,7 +51,7 @@ > *** Testing chunk_split() : different 'chunklen' with heredoc 'str' *** > -- Iteration 1 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 2 -- > string(504) "T:::h:::i:::s:::':::s::: :::h:::e:::r:::e:::d:::o:::c::: > :::s:::t:::r:::i:::n:::g::: > :::w:::i:::t:::h::: ::: ::: :::a:::n:::d::: ::: > @@ -60,7 +60,7 @@ > :::c:::h:::u:::n:::k:::_:::s:::p:::l:::i:::t:::(:::):::" > -- Iteration 3 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 4 -- > string(129) "This's heredoc string with and > @@ -79,10 +79,10 @@ > chunk_split():::" > -- Iteration 7 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > -- Iteration 8 -- > > -Warning: chunk_split(): Chunk length should be greater than zero in %s on line %d > +Warning: chunk_split(): Chunk length should be greater than zero. in %s on line %d > bool(false) > Done Best regards, Marcus