Re: Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt
| From: | Johannes Schlüter | Date: | Fri, 16 Nov 2007 10:27:52 +0000 |
| Subject: | Re: Re: cvs: php-src /ext/pdo pdo_sql_parser.c pdo_sql_parser.re /ext/pdo/tests bug_43130.phpt | ||
| References: | 1 2 3 4 5 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to php-cvs+get-47197@lists.php.net to get a copy of this message | ||
Lukas,
On Wed, 2007-11-14 at 16:49 +0100, Lukas Kahwe Smith wrote:
> On 01.11.2007, at 00:56, Lorenzo Alberton wrote:
>
> > Lukas Kahwe Smith wrote:
> >> I talked to Christopher Jones (of Oracle fame) and Lorenzo (MDB2
> >> maintainer). Its clear that the only named parameter supporting
> >> database I know does not support dash inside named parameters. Its
> >> also dangerous since it means that whitespace typos could have
> >> serious hard to spot issues. I think a safe regexp for bound
> >> parameters would look something like: /^[a-z0-9][a-z0-9_]{0,30}$/
> >
> > Since I couldn't find any official reference in
> > the oracle documentation, I did further tests.
[...]
> so please someone revert this change ... or better yet implement the
> above rules.
I won't like having vendor specific rules there but a subset which works
with most/all backends and which should full-fill most user's needs. The
regexp from above looks like a good compromise for me.
johannes