Re[2]: [PHP-CVS] cvs: php4 /ext/midgard config.m4 config.m4.session

Hello James, Thursday, March 29, 2001, 2:09:17 PM, you wrote: >> On Thu, Mar 29, 2001 at 11:50:29AM +0100, James Moore wrote: >> > >> > > ab Thu Mar 29 02:35:33 2001 EDT >> > > >> > > Modified files: >> > > /php4/ext/midgard config.m4 config.m4.session >> > > Log: >> > > - Typo fixed >> > > - config.m4.session updated to config.m4 >> > >> > What does this fix do?? does it need to be included in 4.0.5?? >> or will ming >> > work without it?? >> 1) It is not ming but midgard >> >> 2) It does add libmidgard.so into the list of linked libraries. Yes, it >> need to be included into 4.0.5 > Hmm.. we dont really want another RC if we can avoid it.. whats the best > thing to do here people? Alex, what happens if its not in 4.0.5?? is it > related to somthing that has been changed in midgard recently (IE isnt in > the RC Branch?) or is it a long term issue that has needed fixing? If It is not related to Midgard itself but it was an error caused by porting PHP module for Midgard to PHP4. I assume that it is general way to add libraries with path in to steps: 1. AC_ADD_LIBRARY_WITH_PATH(library, path, FOO_SHARED_LIBADD) 2. PHP_SUBST(FOO_SHARED_LIBADD) In past second step wasn't done correctly in revision 1.6 (if memory serves me) of config.m4. This commit fixes following error: extension uses functions provided by libmidgard.so but was not linked against it. > midgard doesnt work without this change then I suppose it will have to go > into 4.0.5 and we will probably need another (quick) RC otherwise I think it > can probably wait until 4.0.6. Also can some of you midgard guys build and > check the latest RC[4] to make sure midgard works etc as I dont think anyone > else is. I think this should be in 4.0.5 or Midgard PHP4 extension will be unusable for masses. I'll do test rebuild with RC4 tonight but could somebody point me to tarball with it on the php.net site? My connection works faster with HTTP traffic than with CVS checkouts. -- Best regards, Alexander mailto:ab@avilink.net