Re: cvs: php-src(PHP_5_3) /ext/standard basic_functions.c basic_functions.h /ext/standard/tests/general_functions ini_get_all.phpt

Hannes Magnusson kirjoitti:

On Mon, Apr 14, 2008 at 5:40 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote:

Eh..do you really understand the code correctly..? ini_get_all() is very much different what config_dump_hash() was/is.

Uhh.. I don't see the difference. And there are no tests to compare it against. I already asked on internals@ and after no reply I tracked down helly on IRC and he was fine with merging them.

This function was originally just meant for debugging the config hash. And hint for the difference is: registered vs. anything (that was freebie..) Rule 1: Learn how to use CVS before you commit (hint: cvs annotate filename.ext) Rule 2: Once you learned how to use CVS and figured out who to ask: ASK. Rule 3: Ask the right people before committing. Rule 4: IRC != internals@ (I haven't seen ANY question about this on internals!) Now be good boy and revert the crap, that function is VERY useful for debugging how the php.ini stuff works (or not) and should be there. It was originally only enabled for debug builds and should always still be, I've no idea why Marcus made it enabled always in the first place.. --Jani