Re: cvs: php4 /ext/exif exif.c
| From: | Andi Gutmans | Date: | Tue, 03 Apr 2001 22:08:06 +0000 |
| Subject: | Re: cvs: php4 /ext/exif exif.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-4968@lists.php.net to get a copy of this message | ||
Daniel,
Why not use virtual_filepath() always and make one case out of your code. It also works in non VIRTUAL_DIR mode. There shouldn't really be #ifdef's in the PHP code (TSRM takes care of it). If it's a specific problem we can think of how to fix it.
Andi
At 09:39 PM 4/3/2001 +0000, Daniel Beulshausen wrote:
dbeu Tue Apr 3 14:39:18 2001 EDTModified files:/php4/ext/exif exif.cLog: resolve realpath if in v-dir mode Index: php4/ext/exif/exif.c diff -u php4/ext/exif/exif.c:1.12 php4/ext/exif/exif.c:1.13 --- php4/ext/exif/exif.c:1.12 Sun Feb 25 22:06:54 2001+++ php4/ext/exif/exif.c Tue Apr 3 14:39:18 2001@@ -1060,7 +1060,7 @@pval **p_name; int ac = ZEND_NUM_ARGS(), ret; ImageInfoType ImageInfo; - char tmp[64]; + char tmp[64], *file;/*ImageInfo.Thumbnail = NULL; ImageInfo.ThumbnailSize = 0;@@ -1070,7 +1070,14 @@WRONG_PARAM_COUNT;convert_to_string_ex(p_name); - ret = php_read_jpeg_exif(&ImageInfo, (*p_name)->value.str.val,1);+ +#ifdef VIRTUAL_DIR+ virtual_filepath(Z_STRVAL_PP(p_name), &file); + ret = php_read_jpeg_exif(&ImageInfo, file,1);+#else+ ret = php_read_jpeg_exif(&ImageInfo, Z_STRVAL_PP(p_name),1);+#endif +if (array_init(return_value) == FAILURE) { RETURN_FALSE; }-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net