Re: Re: cvs: php-src(PHP_5_3) /ext/ereg ereg.c
| From: | Felipe Pena | Date: | Sun, 20 Apr 2008 01:18:37 +0000 |
| Subject: | Re: Re: cvs: php-src(PHP_5_3) /ext/ereg ereg.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-49683@lists.php.net to get a copy of this message | ||
Em Dom, 2008-04-20 às 03:06 +0200, Johannes Schlüter escreveu:
> On Wed, 2008-04-09 at 13:51 +0000, "Felipe Pena" wrote:
> > felipe Wed Apr 9 13:51:09 2008 UTC
> >
> > Modified files: (Branch: PHP_5_3)
> > /php-src/ext/ereg ereg.c
> > Log:
> > MFB: Fixed bug #44678 (spliti error message includes wrong function name)
> [...]
> > + if (icase) {
> > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid Regular Expression to
> > spliti()");
> > + } else {
> > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid Regular Expression to
> > split()");
> > + }
> > +
>
> won't "Invalid Regular Expression" be enough as the fucntion nameis
> added by php_error_docref? And are there no tests for that? :-)
Oh, really! ;)
--
Regards,
Felipe Pena.