Re: cvs: php-src /ext/reflection config.m4
| From: | Jani Taskinen | Date: | Fri, 02 May 2008 14:32:45 +0000 |
| Subject: | Re: cvs: php-src /ext/reflection config.m4 | ||
| References: | 1 | Groups: | php.cvs php.doc |
| Request: | Send a blank email to php-cvs+get-49804@lists.php.net to get a copy of this message | ||
On Fri, 2008-05-02 at 13:06 +0000, Lars Strojny wrote:
> lstrojny Fri May 2 13:06:27 2008 UTC
>
> Modified files:
> /php-src/ext/reflection config.m4
> Log:
> Hard enabling ext/reflection on UNIX too [DOC]
>
>
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/reflection/config.m4?r1=1.6&r2=1.7&diff_format=u
> Index: php-src/ext/reflection/config.m4
> diff -u php-src/ext/reflection/config.m4:1.6 php-src/ext/reflection/config.m4:1.7
> --- php-src/ext/reflection/config.m4:1.6 Wed Aug 23 09:47:07 2006
> +++ php-src/ext/reflection/config.m4 Fri May 2 13:06:27 2008
> @@ -1,10 +1,4 @@
> -dnl $Id: config.m4,v 1.6 2006/08/23 09:47:07 tony2001 Exp $
> +dnl $Id: config.m4,v 1.7 2008/05/02 13:06:27 lstrojny Exp $
> dnl config.m4 for extension reflection
>
> -PHP_ARG_ENABLE(reflection, whether to enable reflection support,
> -[ --disable-reflection Disable reflection support], yes, no)
> -
> -if test "$PHP_REFLECTION" != "no"; then
> - AC_DEFINE(HAVE_REFLECTION, 1, [Whether Reflection is enabled])
> - PHP_NEW_EXTENSION(reflection, php_reflection.c, no)
> -fi
> +PHP_NEW_EXTENSION(reflection, php_reflection.c, no)
Please don't remove the AC_DEFINE(..) line. And god forbid, DO NOT
REMOVE the #ifdef HAVE_REFLECTION (PCRE, etc..) anywhere either and make
it unnecessarily painful for people to disable these extensions.
(as in: rm -rf ext/reflection && ./buildconf ...)
--Jani