Re: cvs: php-src /ext/standard dl.c
| From: | Felipe Pena | Date: | Fri, 16 May 2008 11:02:57 +0000 |
| Subject: | Re: cvs: php-src /ext/standard dl.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-49995@lists.php.net to get a copy of this message | ||
Em Sex, 2008-05-16 às 11:40 +0400, Antony Dovgal escreveu:
> On 16.05.2008 07:11, Felipe Pena wrote:
> > - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z", &filename) ==
> > FAILURE) {
> > + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "z/", &filename) ==
> > FAILURE) {
> > return;
> > }
> > +
> > + convert_to_string(filename);
>
> Why not use "s" ?
> That would also give you nice notices when you pass in non-scalar values.
Because php_dl() expects zval* and i thought to keep it.
But, i'll change, whereas php_dl() doesn't make anything with zvals.
--
Regards,
Felipe Pena.