Re: cvs: php4 /ext/fdf fdf.c php_fdf.h

On Fri, Apr 06, 2001 at 11:17:32PM -0000, Jani Taskinen wrote: > sniper Fri Apr 6 16:17:32 2001 EDT > > Modified files: > /php4/ext/fdf fdf.c php_fdf.h > Log: > Fixed some bugs. Why are you changing in the describtions of protos "Sets" to "Set", "Adds" to "Add" and so on? I think the former was the right english description. Please look into CODING_STANDARDS at php.net and phpdoc/funcsummary.txt. Most descriptions starts with "Sets" or "Adds" which is IMHO the right way to go and the example in CODING_STANDARDS could be changed. Notice also, some people are adding a punctuation mark, which looks bad. I hope Rasmus will give some advice, how we should do this in the future. I have just reread that small chapter "Documentation and Folding Hooks" in CODING_STANDARDS. Compare the two examples and you know what I am speaking off (add a "s" to Return in the first example and remove the punctuation mark in the second example). -Egon -- LinuxTag, Stuttgart, Germany: July 5-8 2001: http://www.linuxtag.de/ All known books about PHP and related books: http://php.net/books.php Concert Band of the University of Hohenheim: http://www.concert-band.de/ First and second bestselling book in German: http://www.php-buch.de/