Re: cvs: php-src(PHP_5_3) /tests/classes __call_005.phpt ZendEngine2 zend_compile.c ZendEngine2/tests magic_methods_001.phpt magic_methods_002.phpt
magic_methods_003.phpt magic_methods_004.phpt magic_methods_005.phpt magic_methods_006.phpt magic_methods_007.phpt magic_methods_008.phpt
magic_methods_009.phpt magic_methods_010.phpt

From: Date: Tue, 10 Jun 2008 13:30:51 +0000
Subject: Re: cvs: php-src(PHP_5_3) /tests/classes __call_005.phpt ZendEngine2 zend_compile.c ZendEngine2/tests magic_methods_001.phpt magic_methods_002.phpt
magic_methods_003.phpt magic_methods_004.phpt magic_methods_005.phpt magic_methods_006.phpt magic_methods_007.phpt magic_methods_008.phpt
magic_methods_009.phpt magic_methods_010.phpt
References: 1 2  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-50351@lists.php.net to get a copy of this message
I think Framework is wrong here. Magic access handlers should be public, otherwise it's unclear what's supposed to happen when you access something and access handler is not visible. __ctor, __clone is ok now, not sure about __toString - generally allowing protecting __toString and throwing error if not accessible might be ok, though I don't see real use case for it... Dmitry Stogov wrote:
Hi Felipe, This patch breaks some existent code that worked fine before 5.3 (for example ZendFramework).
-- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com

« previous php.cvs (#50351) next »