Re: cvs: php-src(PHP_5_3) / run-tests.php

From: Date: Thu, 19 Jun 2008 21:17:03 +0000
Subject: Re: cvs: php-src(PHP_5_3) / run-tests.php
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-50491@lists.php.net to get a copy of this message
+ + $timeout = $leak_check ? 300 : (isset($env['TEST_TIMEOUT']) ? $env['TEST_TIMEOUT'] : 60);
I don't particularly like this semantic, as that way I can't set the timeout when using valgrind. A better way would be (IMHO): $timeout = isset($env['TEST_TIMEOUT']) ? $env['TEST_TIMEOUT'] : ($leak_check ? 300 : 60); Also, maybe it's time to put the timeout value computation outside of the function, otherwise that's two ifs for each test execution + skipif execution. Anyway this seems a great addition, as now I can fine tune the timeout without editing the script by hand. Nuno

« previous php.cvs (#50491) next »