Re: cvs: php-src(PHP_5_3) /ext/phar phar.c tar.c zip.c /ext/phar/tests cached_manifest_1.phpt
| From: | Gregory Beaver | Date: | Fri, 20 Jun 2008 04:50:17 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/phar phar.c tar.c zip.c /ext/phar/tests cached_manifest_1.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-50497@lists.php.net to get a copy of this message | ||
Steph Fox wrote:
> sfox Wed Jun 18 15:06:50 2008 UTC
>
> Modified files: (Branch: PHP_5_3)
> /php-src/ext/phar phar.c tar.c zip.c
> /php-src/ext/phar/tests cached_manifest_1.phpt
> Log:
> - Kill 10 MSVC compiler warnings due to type conflict
> - Make cached manifest test platform agnostic
> - Comment out zend_(init|destroy)_rsrc_list() and associated references
>
> @Greg: cached manifest test (now) passes here regardless, make of that what you will
cellog@lot-49:~/workspace/php5/ext/phar$ ../../sapi/cli/php -c
../../php.ini ../../run-tests.php -c /home/cellog/workspace/php5/php.ini
tests
Segmentation fault
What part of "it segfaults on my system with these commented out" is
unclear?
Reverting this commit in 3 seconds with a more intelligent solution.
Also, // comments should be /* */, not that it really matters after the
next commit :).
Greg